mirror of
https://github.com/bitnami/charts.git
synced 2026-03-16 06:47:30 +08:00
test(all): 🚑 Fix incorrect chart changes detection (#9024)
Signed-off-by: Javier Salmeron Garcia <jsalmeron@vmware.com>
This commit is contained in:
committed by
GitHub
parent
71f3012093
commit
13b8419190
4
.github/workflows/vib-early-feedback.yaml
vendored
4
.github/workflows/vib-early-feedback.yaml
vendored
@@ -29,14 +29,14 @@ jobs:
|
|||||||
run: |
|
run: |
|
||||||
files_changed="$(git diff --name-only origin/master HEAD)"
|
files_changed="$(git diff --name-only origin/master HEAD)"
|
||||||
# Adding || true to avoid "Process exited with code 1" errors
|
# Adding || true to avoid "Process exited with code 1" errors
|
||||||
charts_dirs_changed="$(echo "$files_changed" | xargs dirname | grep "bitnami/"| sort | uniq || true)"
|
charts_dirs_changed="$(echo "$files_changed" | xargs dirname | grep -o "bitnami/[^/]*" | sort | uniq || true)"
|
||||||
# Using grep -c as a better alternative to wc -l when dealing with empty strings."
|
# Using grep -c as a better alternative to wc -l when dealing with empty strings."
|
||||||
num_charts_changed="$(echo "$charts_dirs_changed" | grep -c "bitnami" || true)"
|
num_charts_changed="$(echo "$charts_dirs_changed" | grep -c "bitnami" || true)"
|
||||||
num_version_bumps="$(echo "$charts_dirs_changed" | grep Chart.yaml | xargs git diff origin/master | grep -c "+version" || true)"
|
num_version_bumps="$(echo "$charts_dirs_changed" | grep Chart.yaml | xargs git diff origin/master | grep -c "+version" || true)"
|
||||||
|
|
||||||
if [[ "$num_charts_changed" -ne "$num_version_bumps" ]]; then
|
if [[ "$num_charts_changed" -ne "$num_version_bumps" ]]; then
|
||||||
# Changes done in charts but version not bumped -> ERROR
|
# Changes done in charts but version not bumped -> ERROR
|
||||||
echo "::set-output name=error::Detected changes in charts without version bump in Chart.yaml.\nCharts changed:\n${charts_dirs_changed}\nVersion bumps detected: ${num_version_bumps}"
|
echo "::set-output name=error::Detected changes in charts without version bump in Chart.yaml.\nCharts changed: ${num_charts_changed}\n${charts_dirs_changed}\nVersion bumps detected: ${num_version_bumps}"
|
||||||
echo "::set-output name=result::fail"
|
echo "::set-output name=result::fail"
|
||||||
elif [[ "$num_charts_changed" -eq "1" ]]; then
|
elif [[ "$num_charts_changed" -eq "1" ]]; then
|
||||||
# Changes done in only one chart -> OK
|
# Changes done in only one chart -> OK
|
||||||
|
|||||||
Reference in New Issue
Block a user