From 13eaa3fdfd8e27317c99d0eef5747e3cca357a26 Mon Sep 17 00:00:00 2001 From: Geert Pante <93338556+geertp-ngdata@users.noreply.github.com> Date: Wed, 4 May 2022 11:55:25 +0200 Subject: [PATCH] [bitnami/kafka] Append zookeeperChrootPath when using external zookeeper. (#9990) * Append zookeeperChrootPath when using external zookeeper. When using an external zookeeper, it's important to use a root path where kafka keeps its data. There is a zookeeperChrootPath value, but it was ignored when using externalZookeeper.servers. Signed-off-by: Geert Pante * [bitnami/kafka] Bump to 16.2.10 Signed-off-by: Geert Pante --- bitnami/kafka/Chart.yaml | 2 +- bitnami/kafka/README.md | 2 +- bitnami/kafka/templates/statefulset.yaml | 2 +- bitnami/kafka/values.yaml | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/bitnami/kafka/Chart.yaml b/bitnami/kafka/Chart.yaml index d0e6929d74..70ddc3d332 100644 --- a/bitnami/kafka/Chart.yaml +++ b/bitnami/kafka/Chart.yaml @@ -29,4 +29,4 @@ name: kafka sources: - https://github.com/bitnami/bitnami-docker-kafka - https://kafka.apache.org/ -version: 16.2.9 +version: 16.2.10 diff --git a/bitnami/kafka/README.md b/bitnami/kafka/README.md index 3bea3fe1fa..a6ecc505eb 100644 --- a/bitnami/kafka/README.md +++ b/bitnami/kafka/README.md @@ -455,7 +455,7 @@ The command removes all the Kubernetes components associated with the chart and | `zookeeper.persistence.storageClass` | Persistent Volume storage class | `""` | | `zookeeper.persistence.accessModes` | Persistent Volume access modes | `["ReadWriteOnce"]` | | `zookeeper.persistence.size` | Persistent Volume size | `8Gi` | -| `externalZookeeper.servers` | List of external zookeeper servers to use | `[]` | +| `externalZookeeper.servers` | List of external zookeeper servers to use. Typically used in combination with 'zookeeperChrootPath'. | `[]` | Specify each parameter using the `--set key=value[,key=value]` argument to `helm install`. For example, diff --git a/bitnami/kafka/templates/statefulset.yaml b/bitnami/kafka/templates/statefulset.yaml index 458de2486b..4b5eefc3b5 100644 --- a/bitnami/kafka/templates/statefulset.yaml +++ b/bitnami/kafka/templates/statefulset.yaml @@ -181,7 +181,7 @@ spec: {{- if .Values.zookeeper.enabled }} value: {{ printf "%s%s" (include "kafka.zookeeper.fullname" .) (tpl .Values.zookeeperChrootPath .) | quote }} {{- else }} - value: {{ include "common.tplvalues.render" (dict "value" (join "," .Values.externalZookeeper.servers) "context" $) }} + value: {{ include "common.tplvalues.render" (dict "value" (printf "%s%s" (join "," .Values.externalZookeeper.servers) (tpl .Values.zookeeperChrootPath .)) "context" $) }} {{- end }} - name: KAFKA_INTER_BROKER_LISTENER_NAME value: {{ .Values.interBrokerListenerName | quote }} diff --git a/bitnami/kafka/values.yaml b/bitnami/kafka/values.yaml index bf8bd2a0be..ffabe9e14b 100644 --- a/bitnami/kafka/values.yaml +++ b/bitnami/kafka/values.yaml @@ -1616,6 +1616,6 @@ zookeeper: ## All of these values are only used if `zookeeper.enabled=false` ## externalZookeeper: - ## @param externalZookeeper.servers List of external zookeeper servers to use + ## @param externalZookeeper.servers List of external zookeeper servers to use. Typically used in combination with 'zookeeperChrootPath'. ## servers: []