From 5e18a51c161be6d309c203f7eb7ed599caf172e4 Mon Sep 17 00:00:00 2001 From: Hritik Date: Wed, 24 Apr 2024 15:58:03 +0530 Subject: [PATCH] [bitnami/mlflow] - make MLFLOW_S3_ENDPOINT_URL env option in tracking mlflow container (#25294) * make MLFLOW_S3_ENDPOINT_URL env option in mlflow container Signed-off-by: hritik.kumar@telekom-digital.com * update README.md Signed-off-by: hritik.kumar@telekom-digital.com * update chart version and revert minio enabled value Signed-off-by: hritik.kumar@telekom-digital.com * Update README.md with readme-generator-for-helm Signed-off-by: Bitnami Containers Signed-off-by: hritik.kumar@telekom-digital.com * correct chart Version and tracking deployment env Signed-off-by: hritik.kumar@telekom-digital.com * revert waitContainer related changes Signed-off-by: hritik.kumar@telekom-digital.com * Update bitnami/mlflow/README.md Signed-off-by: David Gomez --------- Signed-off-by: hritik.kumar@telekom-digital.com Signed-off-by: Bitnami Containers Signed-off-by: David Gomez Co-authored-by: hritik.kumar@telekom-digital.com Co-authored-by: Bitnami Containers Co-authored-by: David Gomez --- bitnami/mlflow/Chart.yaml | 2 +- bitnami/mlflow/templates/tracking/deployment.yaml | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/bitnami/mlflow/Chart.yaml b/bitnami/mlflow/Chart.yaml index df5ce6d83d..a8bbfef74a 100644 --- a/bitnami/mlflow/Chart.yaml +++ b/bitnami/mlflow/Chart.yaml @@ -43,4 +43,4 @@ name: mlflow sources: - https://github.com/bitnami/containers/tree/main/bitnami/mlflow - https://github.com/mlflow/mlflow -version: 1.0.2 +version: 1.0.3 \ No newline at end of file diff --git a/bitnami/mlflow/templates/tracking/deployment.yaml b/bitnami/mlflow/templates/tracking/deployment.yaml index 0a849cf2d2..3bbcb6cdee 100644 --- a/bitnami/mlflow/templates/tracking/deployment.yaml +++ b/bitnami/mlflow/templates/tracking/deployment.yaml @@ -185,6 +185,8 @@ spec: name: {{ include "mlflow.v0.s3.secretName" . }} key: {{ include "mlflow.v0.s3.secretAccessKeyKey" . | quote }} {{- end }} + {{- end }} + {{- if .Values.minio.enabled }} - name: MLFLOW_S3_ENDPOINT_URL value: {{ printf "%s://%s:%v" (include "mlflow.v0.s3.protocol" .) (include "mlflow.v0.s3.host" .) (include "mlflow.v0.s3.port" .) | quote }} {{- end }}