[bitnami/clickhouse] Fix clickhouse VPA apiVersion and template (#36442)

* fix: correct context reference for custom labels in VerticalPodAutoscaler metadata

Fixes #36439

fix: update apiVersion for Vertical Pod Autoscaler to use autoscaling.k8s.io/v1

Fixes #36303

chore: bump ClickHouse chart version to 9.4.6
chore: bump version to 2.31.8 in Chart.yaml

Signed-off-by: Per Osbäck <per@osbeck.com>

* Apply suggestion from @jotamartos

Signed-off-by: Juan José Martos <jota.martos@broadcom.com>

* Remove old VPA apiVersion reference

Removed outdated Vertical Pod Autoscaler apiVersion handling.

Signed-off-by: Juan José Martos <jota.martos@broadcom.com>

---------

Signed-off-by: Per Osbäck <per@osbeck.com>
Signed-off-by: Juan José Martos <jota.martos@broadcom.com>
Co-authored-by: Juan José Martos <jota.martos@broadcom.com>

bitnami/clickhouse/Chart.yaml

@@ -33,4 +33,4 @@ maintainers:
 name: clickhouse
 sources:
 - https://github.com/bitnami/charts/tree/main/bitnami/clickhouse
-version: 9.4.5
+version: 9.4.6

bitnami/clickhouse/templates/vpa.yaml

@@ -11,7 +11,7 @@ kind: VerticalPodAutoscaler
 metadata:
   name: {{ printf "%s-shard%d" (include "common.names.fullname" $ ) $i }}
   namespace: {{ include "common.names.namespace" $ | quote }}
-  labels: {{- include "common.labels.standard" (dict "customLabels" .Values.commonLabels "context" .) | nindent 4 }}
+  labels: {{- include "common.labels.standard" (dict "customLabels" $.Values.commonLabels "context" $) | nindent 4 }}
     app.kubernetes.io/component: clickhouse
     app.kubernetes.io/part-of: clickhouse
   {{- if or $.Values.autoscaling.vpa.annotations $.Values.commonAnnotations }}

bitnami/common/Chart.yaml

@@ -22,4 +22,4 @@ name: common
 sources:
   - https://github.com/bitnami/charts/tree/main/bitnami/common
 type: library
-version: 2.31.7
+version: 2.31.8

bitnami/common/templates/_capabilities.tpl

@@ -115,12 +115,7 @@ Return the appropriate apiVersion for Horizontal Pod Autoscaler.
 Return the appropriate apiVersion for Vertical Pod Autoscaler.
 */}}
 {{- define "common.capabilities.vpa.apiVersion" -}}
-{{- $kubeVersion := include "common.capabilities.kubeVersion" . -}}
-{{- if and (not (empty $kubeVersion)) (semverCompare "<1.25-0" $kubeVersion) -}}
-{{- print "autoscaling/v1beta2" -}}
-{{- else -}}
-{{- print "autoscaling/v1" -}}
-{{- end -}}
+{{- print "autoscaling.k8s.io/v1" -}}
 {{- end -}}
 
 {{/*