From c4196e0c9a212ab3810ab85e12ed3c7fbb925a2d Mon Sep 17 00:00:00 2001 From: David Gomez Date: Tue, 21 May 2024 09:05:26 +0200 Subject: [PATCH] [bitnami/deepspeed] Use different liveness/readiness probes (#26121) Signed-off-by: David Gomez --- bitnami/deepspeed/Chart.yaml | 2 +- bitnami/deepspeed/templates/client/client-dep-job.yaml | 2 +- bitnami/deepspeed/templates/worker/worker-statefulset.yaml | 7 +++++-- 3 files changed, 7 insertions(+), 4 deletions(-) diff --git a/bitnami/deepspeed/Chart.yaml b/bitnami/deepspeed/Chart.yaml index 7efee1d89b..eb70b57844 100644 --- a/bitnami/deepspeed/Chart.yaml +++ b/bitnami/deepspeed/Chart.yaml @@ -35,4 +35,4 @@ name: deepspeed sources: - https://github.com/bitnami/charts/tree/main/bitnami/deepspeed - https://github.com/bitnami/charts/tree/main/bitnami/pytorch -version: 2.0.5 +version: 2.0.6 diff --git a/bitnami/deepspeed/templates/client/client-dep-job.yaml b/bitnami/deepspeed/templates/client/client-dep-job.yaml index 3f97ae2952..d6dc136405 100644 --- a/bitnami/deepspeed/templates/client/client-dep-job.yaml +++ b/bitnami/deepspeed/templates/client/client-dep-job.yaml @@ -160,7 +160,7 @@ spec: command: - python - -c - - import deepspeed; deepspeed.__version__ + - import torch; torch.__version__ {{- end }} {{- if .Values.client.customReadinessProbe }} readinessProbe: {{- include "common.tplvalues.render" (dict "value" .Values.client.customReadinessProbe "context" $) | nindent 12 }} diff --git a/bitnami/deepspeed/templates/worker/worker-statefulset.yaml b/bitnami/deepspeed/templates/worker/worker-statefulset.yaml index fcce5d92ae..115c555414 100644 --- a/bitnami/deepspeed/templates/worker/worker-statefulset.yaml +++ b/bitnami/deepspeed/templates/worker/worker-statefulset.yaml @@ -154,8 +154,11 @@ spec: livenessProbe: {{- include "common.tplvalues.render" (dict "value" .Values.worker.customLivenessProbe "context" $) | nindent 12 }} {{- else if .Values.worker.livenessProbe.enabled }} livenessProbe: {{- include "common.tplvalues.render" (dict "value" (omit .Values.worker.livenessProbe "enabled") "context" $) | nindent 12 }} - tcpSocket: - port: tcp-ssh + exec: + command: + - pgrep + - -f + - sshd {{- end }} {{- if .Values.worker.customReadinessProbe }} readinessProbe: {{- include "common.tplvalues.render" (dict "value" .Values.worker.customReadinessProbe "context" $) | nindent 12 }}