mirror of
https://github.com/bitnami/charts.git
synced 2026-03-10 15:07:49 +08:00
extra manifests declared with the `extraDeploy` value used to be defined in a single List manifest. the issue with this setup, is that if you want to define a Job to be used as a Helm hook, it won't work - because Helm only look at top-level manifests to find the hook annotations. this PR changes the implementation of extra manifests, by rendering top-level manifests instead of wrapping them inside a List. charts users don't need to change anything in their values.yaml
This directory contains a basic scaffolding to serve as the basis for creating a new chart.
Some of the items that need to be implemented are:
- commonAnnotations
- commonLabels
- imagePullSecret
- extraDeploy
- resources.requests
- resources.limits
- livenessProbe
- readinessProbe
- customLivenessProbe
- customReadinessProbe
- podLabels
- affinity
- nodeSelector
- tolerations (that would override the default one)
- podAnnotations
- priorityClassName
- lifecycleHooks
- sidecars
- initContainers
- extraEnvVars
- extraEnvVarsCM
- extraEnvVarsSecret
- command (which would override the default one)
- args (which would override the default one)
- extraVolumes
- extraVolumeMounts
- updateStrategy
- podSecurityContext
- containerSecurityContext
Also it is necessary to use the bitnami/common chart to standarize some of the above items.
⚠️ Take into account this is just an example to follow, depending on the specifc use case you will need to remove, add or modify those templates, beyond replacing the placeholders %%FOO%%