From 0916cceeac8c4ba61570e92a9e5fd754f33ab995 Mon Sep 17 00:00:00 2001 From: Sameer Naik Date: Tue, 14 Feb 2017 15:36:18 +0530 Subject: [PATCH 1/2] config: move default config var to Dockerfile --- bitnami/rabbitmq/Dockerfile | 9 ++++++++- bitnami/rabbitmq/rootfs/app-entrypoint.sh | 9 --------- 2 files changed, 8 insertions(+), 10 deletions(-) diff --git a/bitnami/rabbitmq/Dockerfile b/bitnami/rabbitmq/Dockerfile index 207fd2e8021c..8e8415908d1d 100644 --- a/bitnami/rabbitmq/Dockerfile +++ b/bitnami/rabbitmq/Dockerfile @@ -17,8 +17,15 @@ RUN bitnami-pkg unpack rabbitmq-3.6.6-2 --checksum a45b57ff8ba832ef005721f120270 COPY rootfs / -VOLUME ["/bitnami/rabbitmq"] +ENV RABBITMQ_VHOST="/" \ + RABBITMQ_USERNAME="user" \ + RABBITMQ_PASSWORD="bitnami" \ + RABBITMQ_NODE_TYPE="stats" \ + RABBITMQ_NODE_PORT="5672" \ + RABBITMQ_NODE_NAME="rabbit@localhost" \ + RABBITMQ_MANAGER_PORT="15672" +VOLUME ["/bitnami/rabbitmq"] EXPOSE 4369 5672 25672 15672 diff --git a/bitnami/rabbitmq/rootfs/app-entrypoint.sh b/bitnami/rabbitmq/rootfs/app-entrypoint.sh index c6eda825dd7b..7c37c03f827e 100755 --- a/bitnami/rabbitmq/rootfs/app-entrypoint.sh +++ b/bitnami/rabbitmq/rootfs/app-entrypoint.sh @@ -14,15 +14,6 @@ function initialize { fi } -# Set default values -export RABBITMQ_VHOST=${RABBITMQ_VHOST:-"/"} -export RABBITMQ_USERNAME=${RABBITMQ_USERNAME:-"user"} -export RABBITMQ_PASSWORD=${RABBITMQ_PASSWORD:-"bitnami"} -export RABBITMQ_NODE_TYPE=${RABBITMQ_NODE_TYPE:-"stats"} -export RABBITMQ_NODE_PORT=${RABBITMQ_NODE_PORT:-"5672"} -export RABBITMQ_NODE_NAME=${RABBITMQ_NODE_NAME:-"rabbit@localhost"} -export RABBITMQ_MANAGER_PORT=${RABBITMQ_MANAGER_PORT:-"15672"} - if [[ "$1" == "nami" && "$2" == "start" ]] || [[ "$1" == "/init.sh" ]]; then initialize rabbitmq echo "Starting application ..." From cd6726ff8c27f28db2d8edc000d503cf845dda22 Mon Sep 17 00:00:00 2001 From: Sameer Naik Date: Tue, 14 Feb 2017 15:36:25 +0530 Subject: [PATCH 2/2] entrypoint: remove references to `entrypoint.sh` from base image --- bitnami/rabbitmq/Dockerfile | 2 +- bitnami/rabbitmq/rootfs/app-entrypoint.sh | 27 ++++++++--------------- 2 files changed, 10 insertions(+), 19 deletions(-) diff --git a/bitnami/rabbitmq/Dockerfile b/bitnami/rabbitmq/Dockerfile index 8e8415908d1d..5af4b8599d22 100644 --- a/bitnami/rabbitmq/Dockerfile +++ b/bitnami/rabbitmq/Dockerfile @@ -1,4 +1,4 @@ -FROM gcr.io/stacksmith-images/minideb:jessie-r8 +FROM gcr.io/stacksmith-images/minideb:jessie-r9 MAINTAINER Bitnami diff --git a/bitnami/rabbitmq/rootfs/app-entrypoint.sh b/bitnami/rabbitmq/rootfs/app-entrypoint.sh index 7c37c03f827e..db1b47f9a535 100755 --- a/bitnami/rabbitmq/rootfs/app-entrypoint.sh +++ b/bitnami/rabbitmq/rootfs/app-entrypoint.sh @@ -1,22 +1,13 @@ -#!/bin/bash -set -e +#!/bin/bash -e +. /opt/bitnami/base/functions +. /opt/bitnami/base/helpers -function initialize { - # Package can be "installed" or "unpacked" - status=`nami inspect $1` - if [[ "$status" == *'"lifecycle": "unpacked"'* ]]; then - # Clean up inputs - inputs="" - if [[ -f /$1-inputs.json ]]; then - inputs=--inputs-file=/$1-inputs.json - fi - nami initialize $1 $inputs - fi -} +print_welcome_page +check_for_updates & -if [[ "$1" == "nami" && "$2" == "start" ]] || [[ "$1" == "/init.sh" ]]; then - initialize rabbitmq - echo "Starting application ..." +if [[ "$1" == "nami" && "$2" == "start" ]] || [[ "$1" == "/init.sh" ]]; then + nami_initialize rabbitmq + info "Starting rabbitmq..." fi -exec /entrypoint.sh "$@" +exec tini -- "$@"