mirror of
https://gitlab.com/openconnect/ocserv.git
synced 2026-08-08 09:21:48 +08:00
Grigory TreninandNikos Mavrogiannopoulos
74ebc5ec8a
The hostname validation was rejecting any hostname containg a '.' character (eg: 'MacBook-Air.local'). This was overly restrictive and prevented the HOSTNAME environment variable from being populated for a signifficant number of clients, particularly on macOS. Strip the domain suffix from such hostnames instead of discarding them. Signed-off-by: Grigory Trenin <grigory.trenin@gmail.com>
72 lines
2.2 KiB
C
72 lines
2.2 KiB
C
/*
|
|
* Copyright (C) 2016 Nikos Mavrogiannopoulos
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#include <config.h>
|
|
#include <stdio.h>
|
|
#include <stdlib.h>
|
|
#include <string.h>
|
|
#include <assert.h>
|
|
|
|
#include "../src/valid-hostname.c"
|
|
|
|
/* This checks whether the valid_hostname() function works
|
|
* as expected.
|
|
*/
|
|
|
|
char hostname[256];
|
|
|
|
unsigned int test_valid_hostname(const char *s)
|
|
{
|
|
strncpy(hostname, s, sizeof(hostname) - 1);
|
|
hostname[sizeof(hostname) - 1] = '\0';
|
|
|
|
strip_domain(hostname);
|
|
|
|
return valid_hostname(hostname);
|
|
}
|
|
|
|
int main(void)
|
|
{
|
|
/* check invalid hostnames */
|
|
assert(test_valid_hostname("192.168.1.1") == 0);
|
|
assert(test_valid_hostname(".local") == 0);
|
|
assert(test_valid_hostname(".abc.def") == 0);
|
|
assert(test_valid_hostname("-hello") == 0);
|
|
assert(test_valid_hostname("1234!") == 0);
|
|
assert(test_valid_hostname("1234#abc") == 0);
|
|
assert(test_valid_hostname("1234$abc") == 0);
|
|
assert(test_valid_hostname("1234&abc") == 0);
|
|
assert(test_valid_hostname("1234|abc") == 0);
|
|
assert(test_valid_hostname("1234\aabc") == 0);
|
|
assert(test_valid_hostname("1234\babc") == 0);
|
|
|
|
/* check valid hostnames */
|
|
assert(test_valid_hostname("12-hello") != 0);
|
|
assert(test_valid_hostname("1234abc-") != 0);
|
|
assert(test_valid_hostname("1234abc-ABC") != 0);
|
|
assert(test_valid_hostname("ABC-abc1") != 0);
|
|
assert(test_valid_hostname("12345") != 0);
|
|
assert(test_valid_hostname("ABC.abc") != 0 &&
|
|
strcmp(hostname, "ABC") == 0);
|
|
assert(test_valid_hostname("aaa.bbb.ccc") != 0 &&
|
|
strcmp(hostname, "aaa") == 0);
|
|
assert(test_valid_hostname("192.168.1.1234") != 0 &&
|
|
strcmp(hostname, "192") == 0);
|
|
|
|
return 0;
|
|
}
|