mirror of
https://gitlab.com/openconnect/ocserv.git
synced 2026-08-08 09:21:48 +08:00
Dimitri Papadopoulos
0fad7f71ac
This fixes a theoretical risk of overflow. I suspect it's not an issue in practice, but it doesn't hurt to switch to talloc_array() to remove the problem altogether. Also, `talloc_array()` macro returns the proper type. From `talloc.h`: /** * talloc_array - allocate dynamic memory for an array of a given type * @ctx: context to be parent of this allocation, or NULL. * @type: the type to be allocated. * @count: the number of elements to be allocated. * * The talloc_array() macro is a safe way of allocating an array. It is * equivalent to: * * (type *)talloc_size(ctx, sizeof(type) * count); * * except that it provides integer overflow protection for the multiply, * returning NULL if the multiply overflows. /** * talloc_size - allocate a particular size of memory * @ctx: context to be parent of this allocation, or NULL. * @size: the number of bytes to allocate * * The function talloc_size() should be used when you don't have a convenient * type to pass to talloc(). Unlike talloc(), it is not type safe (as it * returns a void *), so you are on your own for type checking. * * Best to use talloc() or talloc_array() instead. Signed-off-by: Dimitri Papadopoulos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>
117 lines
2.7 KiB
C
117 lines
2.7 KiB
C
/*
|
|
* Copyright (C) 2013 Nikos Mavrogiannopoulos
|
|
*
|
|
* This file is part of ocserv.
|
|
*
|
|
* ocserv is free software: you can redistribute it and/or modify it
|
|
* under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation, either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* ocserv is distributed in the hope that it will be useful, but
|
|
* WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#include <config.h>
|
|
#include <stdio.h>
|
|
#include <string.h>
|
|
#include <sys/types.h>
|
|
#include <pwd.h>
|
|
#include <grp.h>
|
|
#include <sec-mod-auth.h>
|
|
#include "auth-unix.h"
|
|
#include "log.h"
|
|
|
|
#ifdef HAVE_GET_USER_AUTH_GROUP
|
|
/* Fills-in groupname, if the user is in a unix group, via getpwnam().
|
|
* Returns -1 if the suggested group doesn't match one the groups, or
|
|
* zero otherwise (an empty group is still success).
|
|
*/
|
|
int get_user_auth_group(const char *username, const char *suggested,
|
|
char *groupname, int groupname_size)
|
|
{
|
|
struct passwd *pwd;
|
|
struct group *grp;
|
|
int ret;
|
|
unsigned int found;
|
|
|
|
groupname[0] = 0;
|
|
|
|
pwd = getpwnam(username);
|
|
if (pwd != NULL) {
|
|
if (suggested != NULL) {
|
|
gid_t groups[MAX_GROUPS];
|
|
int ngroups = ARRAY_SIZE(groups);
|
|
unsigned int i;
|
|
|
|
ret = getgrouplist(username, pwd->pw_gid, groups,
|
|
&ngroups);
|
|
if (ret <= 0) {
|
|
return 0;
|
|
}
|
|
|
|
found = 0;
|
|
for (i = 0; i < ngroups; i++) {
|
|
grp = getgrgid(groups[i]);
|
|
if (grp != NULL &&
|
|
strcmp(suggested, grp->gr_name) == 0) {
|
|
strlcpy(groupname, grp->gr_name,
|
|
groupname_size);
|
|
found = 1;
|
|
break;
|
|
}
|
|
}
|
|
|
|
if (found == 0) {
|
|
oc_syslog(
|
|
LOG_NOTICE,
|
|
"user '%s' requested group '%s' but is not a member",
|
|
username, suggested);
|
|
return -1;
|
|
}
|
|
} else {
|
|
struct group *grp = getgrgid(pwd->pw_gid);
|
|
|
|
if (grp != NULL)
|
|
strlcpy(groupname, grp->gr_name,
|
|
groupname_size);
|
|
}
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
void unix_group_list(void *pool, unsigned int gid_min, char ***groupname,
|
|
unsigned int *groupname_size)
|
|
{
|
|
struct group *grp;
|
|
|
|
setgrent();
|
|
|
|
*groupname_size = 0;
|
|
*groupname = talloc_array(pool, char *, MAX_GROUPS);
|
|
if (*groupname == NULL) {
|
|
goto exit;
|
|
}
|
|
|
|
while ((grp = getgrent()) != NULL && (*groupname_size) < MAX_GROUPS) {
|
|
if (grp->gr_gid >= gid_min) {
|
|
(*groupname)[(*groupname_size)] =
|
|
talloc_strdup(*groupname, grp->gr_name);
|
|
if ((*groupname)[(*groupname_size)] == NULL)
|
|
break;
|
|
(*groupname_size)++;
|
|
}
|
|
}
|
|
|
|
exit:
|
|
endgrent();
|
|
}
|
|
|
|
#endif
|