Add support for helm lint and helm install in PRs via GH Actions (#2721)

.github/ct-install.yaml

@@ -0,0 +1,12 @@
+chart-dirs:
+  - bitnami
+chart-repos:
+  - bitnami=https://charts.bitnami.com/bitnami
+debug: true
+excluded-charts:
+  - common
+  - kubeapps
+  - kibana
+  - kong
+  - mariadb-galera
+remote: origin

.github/ct-lint.yaml

@@ -2,9 +2,9 @@ chart-dirs:
   - bitnami
 chart-repos:
   - bitnami=https://charts.bitnami.com/bitnami
+check-version-increment: true
+debug: true
 remote: origin
 validate-chart-schema: true
 validate-maintainers: true
-debug: true
 validate-yaml: true
-check-version-increment: true

.github/workflows/lint-test.yaml

@@ -3,7 +3,7 @@ name: Lint and Test Charts
 on: pull_request
 
 jobs:
-  lint-test:
+  lint:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
@@ -13,7 +13,24 @@ jobs:
         run: git fetch --prune --unshallow
 
       - name: Run chart-testing (lint)
-        id: lint
         uses: helm/chart-testing-action@v1.0.0-rc.2
         with:
+          config: .github/ct-lint.yaml
           command: lint
+  test:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v2
+
+      - name: Fetch history
+        run: git fetch --prune --unshallow
+
+      - name: Create kind cluster
+        uses: helm/kind-action@v1.0.0-rc.1
+
+      - name: Run chart-testing (install)
+        uses: helm/chart-testing-action@v1.0.0-rc.2
+        with:
+          config: .github/ct-install.yaml
+          command: install

CONTRIBUTING.md

@@ -28,10 +28,11 @@ When submitting a PR make sure that it:
 
 ### PR Approval and Release Process
 
-1. Changes are manually reviewed by Bitnami team members.
-2. Once the changes are accepted, the PR is tested into the CI pipeline, the chart is installed and tested on top of different k8s platforms.
-3. If everything works fine, the `bitnami-bot` will add a new commit to the PR updating all the Docker images tags and dependencies. If something fails, the review process continues.
-4. When the PR passes all tests it is merged in the GitHub master branch and the new version of the chart is pushed to the registry. Please note that may be a slight difference between the appearance of the code in GitHub and the chart in the registry.
+1. Changes are automatically linted and tested using the [`ct` tool](https://github.com/helm/chart-testing) as a [GitHub action](https://github.com/helm/chart-testing-action). Those tests are based on `helm install`, `helm lint` and `helm test` commands and provide quick feedback about the changes in the PR. For those tests, the chart is installed on top of [kind](https://github.com/kubernetes-sigs/kind) and this step is not blocking (as opposed to 3rd step).
+2. Changes are manually reviewed by Bitnami team members.
+3. Once the changes are accepted, the PR is tested into the Bitnami CI pipeline, the chart is installed and tested (verification and functional tests) on top of different k8s platforms.
+4. If everything works fine, the `bitnami-bot` will add a new commit to the PR updating all the Docker images tags and dependencies. If something fails, the review process continues.
+5. When the PR passes all tests it is merged in the GitHub master branch and the new version of the chart is pushed to the registry. Please note that may be a slight difference between the appearance of the code in GitHub and the chart in the registry.
 
 ### Adding a new chart to the repository
 

bitnami/apache/ci/ct-values.yaml

@@ -0,0 +1,2 @@
+service:
+  type: ClusterIP

bitnami/dokuwiki/ci/ct-values.yaml

@@ -0,0 +1,2 @@
+service:
+  type: ClusterIP

bitnami/drupal/ci/ct-values.yaml

@@ -0,0 +1,2 @@
+service:
+  type: ClusterIP

bitnami/ghost/ci/ct-values.yaml

@@ -0,0 +1,2 @@
+service:
+  type: ClusterIP

bitnami/jasperreports/ci/ct-values.yaml

@@ -0,0 +1,2 @@
+service:
+  type: ClusterIP

bitnami/jenkins/ci/ct-values.yaml

@@ -0,0 +1,2 @@
+service:
+  type: ClusterIP

bitnami/joomla/ci/ct-values.yaml

@@ -0,0 +1,2 @@
+service:
+  type: ClusterIP

bitnami/magento/ci/ct-values.yaml

@@ -0,0 +1,2 @@
+service:
+  type: ClusterIP

bitnami/mediawiki/ci/ct-values.yaml

@@ -0,0 +1,2 @@
+service:
+  type: ClusterIP

bitnami/moodle/ci/ct-values.yaml

@@ -0,0 +1,2 @@
+service:
+  type: ClusterIP

bitnami/nginx-ingress-controller/ci/ct-values.yaml

@@ -0,0 +1,2 @@
+service:
+  type: ClusterIP

bitnami/nginx/ci/ct-values.yaml

@@ -0,0 +1,2 @@
+service:
+  type: ClusterIP

bitnami/odoo/ci/ct-values.yaml

@@ -0,0 +1,2 @@
+service:
+  type: ClusterIP

bitnami/opencart/ci/ct-values.yaml

@@ -0,0 +1,2 @@
+service:
+  type: ClusterIP

bitnami/orangehrm/ci/ct-values.yaml

@@ -0,0 +1,2 @@
+service:
+  type: ClusterIP

bitnami/osclass/ci/ct-values.yaml

@@ -0,0 +1,2 @@
+service:
+  type: ClusterIP

bitnami/owncloud/ci/ct-values.yaml

@@ -0,0 +1,2 @@
+service:
+  type: ClusterIP

bitnami/parse/ci/ct-values.yaml

@@ -0,0 +1,2 @@
+service:
+  type: ClusterIP

bitnami/phabricator/ci/ct-values.yaml

@@ -0,0 +1,2 @@
+service:
+  type: ClusterIP

bitnami/phpbb/ci/ct-values.yaml

@@ -0,0 +1,2 @@
+service:
+  type: ClusterIP

bitnami/postgresql-ha/ci/ct-values.yaml

@@ -0,0 +1 @@
+fullnameOverride: test

bitnami/prestashop/ci/ct-values.yaml

@@ -0,0 +1,2 @@
+service:
+  type: ClusterIP

bitnami/redmine/ci/ct-values.yaml

@@ -0,0 +1,2 @@
+service:
+  type: ClusterIP

bitnami/suitecrm/ci/ct-values.yaml

@@ -0,0 +1,2 @@
+service:
+  type: ClusterIP

bitnami/tensorflow-resnet/ci/ct-values.yaml

@@ -0,0 +1,2 @@
+service:
+  type: ClusterIP

bitnami/testlink/ci/ct-values.yaml

@@ -0,0 +1,2 @@
+service:
+  type: ClusterIP

bitnami/tomcat/ci/ct-values.yaml

@@ -0,0 +1,2 @@
+service:
+  type: ClusterIP

bitnami/wildfly/ci/ct-values.yaml

@@ -0,0 +1,2 @@
+service:
+  type: ClusterIP

bitnami/wordpress/ci/ct-values.yaml

@@ -0,0 +1,2 @@
+service:
+  type: ClusterIP