Bitnami/charts
2
0
Fork 0
mirror of https://github.com/bitnami/charts.git synced 2026-02-10 20:27:38 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove values-production references in lint, templates, contributing guidelines, etc (#5138)

Browse Source
This commit is contained in:
Carlos Rodríguez Hernández
2021-01-19 18:05:48 +01:00
committed by GitHub
parent c8ba41c38d
commit d21d1ad94f
4 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
.github/PULL_REQUEST_TEMPLATE.md vendored
View File

@@ -36,6 +36,5 @@ request, mention that information here.-->
- [ ] Chart version bumped in `Chart.yaml` according to [semver](http://semver.org/).
- [ ] Variables are documented in the README.md
- [ ] Title of the PR starts with chart name (e.g. `[bitnami/chart]`)
- [ ] If the chart contains a `values-production.yaml` apart from `values.yaml`, ensure that you implement the changes in both files
:warning: Keep in mind that if you want to make changes to the kubeapps chart, please implement them in the [kubeapps repository](https://github.com/kubeapps/kubeapps/tree/master/chart/kubeapps). This is only a synchronized mirror.

1
CONTRIBUTING.md
View File

@@ -16,7 +16,6 @@ Any type of contribution is welcome; from new features, bug fixes, documentation
When submitting a PR make sure that it:
- Must pass CI jobs for linting and test the changes on top of different k8s platforms. (Automatically done by the Bitnami CI/CD pipeline).
- Must follow [Helm best practices](https://helm.sh/docs/chart_best_practices/).
- Implements changes in both files if the chart contains a _values-production.yaml_ and a _values.yaml_.
- Any change to a chart requires a version bump following [semver](https://semver.org/) principles. This is the version that is going to be merged in the GitHub repository, then our CI/CD system is going to publish in the Helm registry a new patch version including your changes and the latest images and dependencies.
### Documentation Requirements

2
bitnami/elasticsearch/README.md
View File

@@ -356,7 +356,7 @@ You can disable the initContainer using the `sysctlImage.enabled=false` paramete
### Enable bundled Kibana
This Elasticsearch chart contains Kibana as subchart, you can enable it just setting the `global.kibanaEnabled=true` parameter. It is enabled by default using the `values-production.yaml` file.
This Elasticsearch chart contains Kibana as subchart, you can enable it just setting the `global.kibanaEnabled=true` parameter.
To see the notes with some operational instructions from the Kibana chart, please use the `--render-subchart-notes` as part of your `helm install` command, in this way you can see the Kibana and ES notes in your terminal.
### Adding extra environment variables

2
githooks/functions/libyamllint.sh
View File

@@ -94,7 +94,7 @@ run_yaml_lint_chart() {
fi
find "$chart_path"/templates -type f -regex ".*\.yaml" > "$template_yaml_file_list"
for yaml_file in "$chart_path"/values.yaml "$chart_path"/values-production.yaml "$chart_path"/requirements.yaml "$chart_path"/Chart.yaml $(< "$ci_values_file_list"); do
for yaml_file in "$chart_path"/values.yaml "$chart_path"/requirements.yaml "$chart_path"/Chart.yaml $(< "$ci_values_file_list"); do
if [[ -f "$yaml_file" ]] && ! yaml_lint_file "$yaml_file"; then
test_failed=1
fi