100 Commits
Author SHA1 Message Date
Dimitri Papadopoulos 20ee8183a3 Fix Coverity Scan defect
CID 498359: Structurally dead code (UNREACHABLE)
unreachable: This code cannot be reached: conn_close(conn);.

Signed-off-by: Dimitri Papadopoulos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>
2026-07-12 21:13:27 +02:00
Dimitri Papadopoulos 9172e33f46 Functions return ssize_t
Put the return value into a variable of type ssize_t.

This doesn't really fix an actual bug, as any received packat should fit
into an int. However, it helps analyse the code and address or discard
Coverity Scan defects.

Signed-off-by: Dimitri Papadopoulos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>
2026-07-12 21:06:58 +02:00
Dimitri Papadopoulos Orfanos 7e8ce7078f Merge branch 'tmp-wget' into 'master'
ci: wget → curl

See merge request openconnect/ocserv!591
2026-07-09 10:16:51 +03:00
Dimitri Papadopoulos 915f819009 ci: wget → curl
Standardise on `curl` instead of using both `wget` and `curl`.

Signed-off-by: Dimitri Papadopoulos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>
2026-06-25 13:15:06 +02:00
Dimitri Papadopoulos 196350abc1 CONTRIBUTING.md: do not reference make
Signed-off-by: Dimitri Papadopoulos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>
2026-06-14 14:00:46 +02:00
Dimitri Papadopoulos Orfanos fa0a7db1cd Merge branch 'tmp-include' into 'master'
Consistent include files and directives

See merge request openconnect/ocserv!569
2026-06-14 09:35:13 +03:00
Dimitri Papadopoulos c4fdd29a45 Suppress Coverity Scan false positive
** CID 646042:       Insecure data handling  (INTEGER_OVERFLOW)
/src/isolate.c: 59           in compute_worker_data_limit()

Signed-off-by: Dimitri Papadopoulos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>
2026-06-07 10:15:09 +02:00
Dimitri Papadopoulos a2ec3bba9c Consistent include files and directives
* Import system headers as `#include <...>`.
* Import local headers as `#include "..."`.
* Use consistent header guards (starting with `OC_`).

Signed-off-by: Dimitri Papadopoulos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>
2026-06-06 15:23:54 +02:00
Dimitri Papadopoulos 29cf2c93fb Handle RADIUS Access-Challenge State as bytes
`state` is a string we receive from the RADIUS server and we do not
parse but echo back.

According to RFC 2866, all strings we receive from the RADIUS server
are octet strings, not null-terminated strings:
	Note that none of the types in RADIUS terminate with a NUL (hex
	00).  In particular, types "text" and "string" in RADIUS do not
	terminate with a NUL (hex 00).  The Attribute has a length field
	and does not use a terminator.  Text contains UTF-8 encoded 10646
	characters and String contains 8-bit binary data.  Servers and
	servers and clients MUST be able to deal with embedded nulls.
	RADIUS implementers using C are cautioned not to use strcpy()
	when handling strings.

Therefore, ensure we treat `state` as a proper octet string rather
than a null-terminated string.

Resolves: #729

Signed-off-by: Dimitri Papadopoulos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>
2026-06-06 10:45:05 +02:00
Dimitri Papadopoulos Orfanos 1d381c8c9b Merge branch 'tmp-which' into 'master'
tests: `which` → `command -v`

See merge request openconnect/ocserv!573
2026-05-31 19:05:28 +03:00
Dimitri Papadopoulos 34be9e368e tests: whichcommand -v
Use `command -v` instead of `which` because:
* It's built into the shell, avoiding an external dependency on the
  `which` package on Fedora 44.
* It works across all POSIX-compliant shells.
* It's standard across Linux distributions. For example, Fedora 44
  lacks the `which` package by default.

Signed-off-by: Dimitri Papadopoulos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>
2026-05-31 14:17:33 +02:00
Dimitri Papadopoulos Orfanos f8ab3518f7 Merge branch 'tmp-733' into 'master'
Avoid infinite loop in BSD TUN fallback

Closes #733

See merge request openconnect/ocserv!557
2026-05-24 20:49:23 +03:00
Dimitri Papadopoulos d51e5b55c4 Avoid infinite loop in BSD TUN fallback
Fixes #733.

Signed-off-by: Dimitri Papadopoulos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>
2026-05-24 18:10:24 +02:00
Dimitri Papadopoulos 4b216473d5 Fix calculation of avg_auth_time across sec-mod instances
Resolves: #736

Signed-off-by: Dimitri Papadopoulos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>
2026-05-24 11:47:26 +02:00
Dimitri Papadopoulos d91ace7c1d Always use the bundled PCL library
Linux distributions have stopped shipping the Portable Coroutine Library.
There always used the vendored code.

Fixes #663.

Signed-off-by: Dimitri Papadopoulos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>
2026-05-23 17:43:36 +02:00
Dimitri Papadopoulos cdfdc5b495 Add LICENSE files of bundled sotware
Signed-off-by: Dimitri Papadopoulos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>
2026-05-23 16:16:35 +02:00
Dimitri Papadopoulos d95d1ac53e Consistency for readability
Consistency across IPv4 and IPv6 paths. Set `sin_addr` first and then `sin_port`.

Signed-off-by: Dimitri Papadopoulos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>
2026-05-19 23:22:37 +02:00
Dimitri Papadopoulos 550e9327cc Set sa before attempting to set sa->sin6_family
Fixes #711.

Signed-off-by: Dimitri Papadopoulos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>
2026-05-19 23:22:34 +02:00
Dimitri Papadopoulos b97aa4d97f Build against GNU Nettle 4
Fixes #697. Follow-up of !535 / 82572986.

Signed-off-by: Dimitri Papadopoulos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>
2026-05-19 21:23:03 +02:00
Dimitri Papadopoulos Orfanos e67582ba05 Merge branch 'tmp-nettle4' into 'master'
Build against GNU Nettle 4

Closes #697

See merge request openconnect/ocserv!535
2026-05-18 01:57:20 +03:00
Dimitri Papadopoulos d019cd1c84 Do not use uninitialised gnutls_x509_crt_t
Initialise `issuer` at each iteration, since we clean up at each iteration.

Fixes #722.

Signed-off-by: Dimitri Papadopoulos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>
2026-05-17 13:17:14 +02:00
Dimitri Papadopoulos 23a08753e9 Do not use uninitialised pam_handle_t
In case of error in pam_start(3), the content of the `pam_handle_t **pamh`
handle is undefined:
	Following a successful return (PAM_SUCCESS) the contents of
	pamh is a handle that contains the PAM context for successive
	calls to the PAM functions. In an error case is the content
	of pamh undefined.

Although pam_sterror(3) does not use `pamh` in any way, pass plain
`NULL` instead of `pamh`.

Fixes #722.

Signed-off-by: Dimitri Papadopoulos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>
2026-05-17 13:16:23 +02:00
Dimitri Papadopoulos 825729868e Build against GNU Nettle 4
From the NEWS file:
https://git.lysator.liu.se/nettle/nettle/-/blob/master/NEWS

	Interface changes:

	* The _digest functions for hash algorithms, MACs and AEADs no
	  longer take the desired digest size as argument, instead,
	  they always produce the full-size digest. The typedef
	  nettle_hash_digest_func has also been changed accordingly.

Fixes #697.

Signed-off-by: Dimitri Papadopoulos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>
2026-05-17 13:13:39 +02:00
Dimitri Papadopoulos 2e89f38e1e Avoid NULL dereference in case of memory exhaustion
Fixes #721.

Signed-off-by: Dimitri Papadopoulos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>
2026-05-16 15:54:08 +02:00
Dimitri PapadopoulosandNikos Mavrogiannopoulos e4c8d894db Fix typo [ci skip]
Signed-off-by: Dimitri Papadopoulos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>
2026-05-14 08:52:32 +02:00
Dimitri Papadopoulos 5a81433f47 Log messages don't need a trailing \n
Signed-off-by: Dimitri Papadopoulos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>
2026-05-12 08:14:21 +02:00
Dimitri Papadopoulos 0fad7f71ac talloc_size() → talloc_array()
This fixes a theoretical risk of overflow. I suspect it's not an issue in
practice, but it doesn't hurt to switch to talloc_array() to remove the
problem altogether. Also, `talloc_array()` macro returns the proper type.

From `talloc.h`:

	/**
	 * talloc_array - allocate dynamic memory for an array of a given type
	 * @ctx: context to be parent of this allocation, or NULL.
	 * @type: the type to be allocated.
	 * @count: the number of elements to be allocated.
	 *
	 * The talloc_array() macro is a safe way of allocating an array.  It is
	 * equivalent to:
	 *
	 *  (type *)talloc_size(ctx, sizeof(type) * count);
	 *
	 * except that it provides integer overflow protection for the multiply,
	 * returning NULL if the multiply overflows.

	/**
	 * talloc_size - allocate a particular size of memory
	 * @ctx: context to be parent of this allocation, or NULL.
	 * @size: the number of bytes to allocate
	 *
	 * The function talloc_size() should be used when you don't have a convenient
	 * type to pass to talloc(). Unlike talloc(), it is not type safe (as it
	 * returns a void *), so you are on your own for type checking.
	 *
	 * Best to use talloc() or talloc_array() instead.

Signed-off-by: Dimitri Papadopoulos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>
2026-05-11 20:13:35 +02:00
Dimitri Papadopoulos bd5e1636dc Use strerror() and pass proper errno to it
Signed-off-by: Dimitri Papadopoulos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>
2026-05-11 19:57:15 +02:00
Dimitri Papadopoulos Orfanos 3f37c8ea38 Merge branch 'tmp-protoc-c' into 'master'
Address build warning: protoc-c → protoc

See merge request openconnect/ocserv!492
2026-05-11 20:18:28 +03:00
Dimitri Papadopoulos Orfanos d090c79926 Merge branch 'tmp-fedora44-ubuntu26.04' into 'master'
CI: upgrade Fedora and Ubuntu

See merge request openconnect/ocserv!540
2026-05-11 20:17:30 +03:00
Dimitri Papadopoulos 6eb1cef514 This is a Bash script, not plain Bourne
Signed-off-by: Dimitri Papadopoulos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>
2026-05-09 10:16:00 +02:00
Dimitri Papadopoulos c30bd5dca4 Address build warning
[libprotobuf WARNING protoc-gen-c/main.cc:44] `protoc-c` is deprecated. Please use `protoc` instead!

Signed-off-by: Dimitri Papadopoulos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>
2026-05-09 10:16:00 +02:00
Dimitri Papadopoulos ad52625e0e Fix new Clang error
error: assigning to 'char *' from 'const char *' discards qualifiers
       [-Werror,-Wincompatible-pointer-types-discards-qualifiers]

Signed-off-by: Dimitri Papadopoulos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>
2026-05-08 15:08:53 +02:00
Dimitri Papadopoulos 174561dd66 CI: upgrade Fedora and Ubuntu
* Fedora 43 → 44
* Ubuntu 24.04 → 26.02 (we also test Ubuntu 22.04)

Signed-off-by: Dimitri Papadopoulos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>
2026-05-08 14:41:19 +02:00
Dimitri Papadopoulos eb886a7c67 Include <sys:socket.h> for AF_INET
Required to build on FreeBSD 15.

Signed-off-by: Dimitri Papadopoulos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>
2026-05-06 20:33:03 +02:00
Dimitri Papadopoulos 9cc845e9d3 llhttp callbacks should return -1 on error
https://github.com/nodejs/llhttp#llhttp_settings_t

Signed-off-by: Dimitri Papadopoulos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>
2026-05-03 18:41:38 +02:00
Dimitri Papadopoulos OrfanosandNikos Mavrogiannopoulos c0b282576e Fix new Coverity Scan defect
This adds checks in memory allocation, to address the following issue reported by coverity:
** CID 645850:       Null pointer dereferences  (FORWARD_NULL) /tests/ban-ips.c: 84           in main()

Signed-off-by: default avatarDimitri Papadopoulos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>
2026-05-01 19:26:45 +00:00
Dimitri Papadopoulos c4767470eb RFC 952 prohibits trailing hyphen, not only leading hyphen
Signed-off-by: Dimitri Papadopoulos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>
2026-04-17 22:33:11 +02:00
Dimitri Papadopoulos 99650ec7cb Add check to disable adaptive rate limiting
Disable when targeting Linux kernels that do not support Unix socket
monitoring (UNIX_DIAG), like the default OpenWrt kernel.

This will avoid flooding the log with this error message:
	NLM query failed

Signed-off-by: Dimitri Papadopoulos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>
2026-04-17 21:58:37 +02:00
Dimitri Papadopoulos 21eed65a60 Fix typos
Signed-off-by: Dimitri Papadopoulos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>
2026-04-09 21:49:54 +02:00
Dimitri Papadopoulos Orfanos d632aaf046 Merge branch 'fix/ns_name_collision' into 'master'
tests: Fix intermittent namespace conflicts in CI

See merge request openconnect/ocserv!508
2026-03-12 15:36:13 +02:00
Dimitri PapadopoulosandNikos Mavrogiannopoulos a309ecead0 llhttp: updated to latest version 9.3.1
Signed-off-by: Dimitri Papadopoulos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>
2026-03-02 08:19:50 +01:00
Dimitri Papadopoulos Orfanos 834d2fa0e8 Merge branch 'tmp-README-oidc.md' into 'master'
Small doc improvements

See merge request openconnect/ocserv!502
2026-02-04 00:07:29 +02:00
Dimitri Papadopoulos 2b178b22ba Small doc improvements
Signed-off-by: Dimitri Papadopoulos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>
2026-02-01 18:41:51 +01:00
Dimitri Papadopoulos 32979e6519 updated to protobuf 1.5.2
Signed-off-by: Dimitri Papadopoulos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>
2026-01-30 00:55:46 +01:00
Dimitri Papadopoulos Orfanos ba19dcd3be Merge branch 'tmp-NEWS' into 'master'
Fix NEWS file

See merge request openconnect/ocserv!501
2026-01-30 01:53:08 +02:00
Dimitri Papadopoulos Orfanos 360e4714e3 Merge branch 'bugfix/ban-json' into 'master'
occtl: Fix 'show ip bans' may produce invalid JSON (#683)

Closes #683

See merge request openconnect/ocserv!495
2026-01-26 09:16:47 +02:00
Dimitri Papadopoulos Orfanos 3ac91eeb2a Merge branch 'gitignore' into 'master'
.gitignore: add generated and cleanup legacy files (gnulib, libopts)

See merge request openconnect/ocserv!496
2026-01-26 09:16:00 +02:00
Dimitri Papadopoulos 842bccc283 Fix NEWS file
Signed-off-by: Dimitri Papadopoulos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>
2026-01-26 08:15:23 +01:00
Dimitri Papadopoulos 592745b8b9 inih: silence static analysis error
Signed-off-by: Dimitri Papadopoulos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>
2026-01-25 13:22:37 +01:00
Dimitri Papadopoulos 28252bff8f inih: increased max line size
Re-apply e7233819.

Signed-off-by: Dimitri Papadopoulos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>
2026-01-25 13:22:37 +01:00
Dimitri Papadopoulos 44d58a049c inih: updated to latest version r62
Signed-off-by: Dimitri Papadopoulos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>
2026-01-25 13:22:37 +01:00
Dimitri Papadopoulos Orfanos 0d58edf884 Merge branch 'bugfix/ban-columns' into 'master'
occtl: Fix column misalignment in ban command outputs

See merge request openconnect/ocserv!490
2026-01-05 17:42:44 +02:00
Dimitri Papadopoulos 79f8eb35f8 Don't forget to initialise udp_port for vhost
Signed-off-by: Dimitri Papadopoulos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>
2026-01-03 11:11:36 +02:00
Dimitri PapadopoulosandNikos Mavrogiannopoulos 300f986a70 .gitlab-ci.yml: forget the Ubuntu 16 image
We don't use UBUNTU_BUILD in CI any more.

Signed-off-by: Dimitri Papadopoulos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>
2026-01-01 17:32:08 +01:00
Dimitri Papadopoulos Orfanos acf8c5bc6a Merge branch 'tmp-do_while' into 'master'
Simplify do/while loops

See merge request openconnect/ocserv!458
2025-12-06 11:39:32 +01:00
Dimitri Papadopoulos Orfanos 86c214feb9 Merge branch 'tmp-printf' into 'master'
Modernize printf() format

See merge request openconnect/ocserv!436
2025-12-06 11:20:28 +01:00
Dimitri Papadopoulos Orfanos c5acc8580e Merge branch 'tmp-llhtp' into 'master'
llhttp: updated to latest version 9.3.0

See merge request openconnect/ocserv!459
2025-12-06 11:15:36 +01:00
Dimitri Papadopoulos Orfanos c545361202 Merge branch 'tmp-CID-356061' into 'master'
Fix issue flagged by Coverity

See merge request openconnect/ocserv!460
2025-12-06 11:14:21 +01:00
Dimitri Papadopoulos Orfanos 31b3d6b930 Merge branch 'tmp-cloexec' into 'master'
Update cloexec.* vendored files

See merge request openconnect/ocserv!439
2025-12-06 11:10:11 +01:00
Dimitri Papadopoulos Orfanos 70a4269e38 Merge branch 'tmp-sigaltstack_RESOURCE_LEAK' into 'master'
Silence coverity

See merge request openconnect/ocserv!446
2025-12-06 11:09:29 +01:00
Dimitri Papadopoulos Orfanos e5de27a316 Merge branch 'tmp-main' into 'master'
Main() signature compliant with C standard

See merge request openconnect/ocserv!438
2025-12-06 11:08:40 +01:00
Dimitri Papadopoulos Orfanos 134ae37a13 Merge branch 'tmp-freeradius-client-1.1.8' into 'master'
Work around API breakage in freeradius-client 1.1.8

Closes #650

See merge request openconnect/ocserv!453
2025-12-06 11:08:18 +01:00
Dimitri Papadopoulos Orfanos 6a65e3acdd Merge branch 'fix-json-output-issues' into 'master'
Fix invalid JSON output in occtl commands

Closes #661 and #669

See merge request openconnect/ocserv!463
2025-12-06 10:54:28 +01:00
Dimitri Papadopoulos Orfanos 0949bfd0db Merge branch 'bugfix/iroute' into 'master'
Fix iroute option processing

Closes #625

See merge request openconnect/ocserv!472
2025-12-01 22:41:21 +01:00
Dimitri Papadopoulos Orfanos 5ff994633c Merge branch 'bugfix/ping-leases' into 'master'
Fix ping-leases option, broken since v1.1.1

See merge request openconnect/ocserv!471
2025-11-22 14:32:40 +01:00
Dimitri Papadopoulos Orfanos 88054ae4c2 Merge branch 'socket-remove' into 'master'
Ignore ENOENT error when removing occtl socket file

See merge request openconnect/ocserv!470
2025-11-21 21:17:51 +01:00
Dimitri Papadopoulos Orfanos 9298a6006c Merge branch 'bugfix/arg-order' into 'master'
Fix swapped arguments in the printf-like call

See merge request openconnect/ocserv!467
2025-11-21 21:08:19 +01:00
Dimitri Papadopoulos Orfanos d817992938 Merge branch 'gperf' into 'master'
build: add gperf check

See merge request openconnect/ocserv!466
2025-11-21 21:07:48 +01:00
Dimitri Papadopoulos Orfanos 33e1b26f43 Merge branch 'ipcalc-not-found' into 'master'
docs: add ipcalc installation in README.md

Closes #659

See merge request openconnect/ocserv!455
2025-11-21 21:04:56 +01:00
Dimitri Papadopoulos Orfanos 77fa214d6b Merge branch 'bugfix/cscot-url' into 'master'
Fix CSCOT URLs handling

See merge request openconnect/ocserv!456
2025-11-21 21:04:02 +01:00
Dimitri Papadopoulos Orfanos 7b92adf29c Merge branch 'non-ascii' into 'master'
Replace non-ASCII character in error message

See merge request openconnect/ocserv!469
2025-11-21 21:03:22 +01:00
Dimitri Papadopoulos cc062ae4aa Fix issue flagged by Coverity
356061 Use of 32-bit time_t

Signed-off-by: Dimitri Papadopoulos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>
2025-09-01 00:58:17 +03:00
Dimitri Papadopoulos cc86919f28 llhttp: updated to latest version 9.3.0
Signed-off-by: Dimitri Papadopoulos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>
2025-08-28 22:17:07 +03:00
Dimitri Papadopoulos 2a2334513c Simplify do/while loops
Signed-off-by: Dimitri Papadopoulos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>
2025-08-27 11:10:59 +03:00
Dimitri Papadopoulos 8b284c645e Work around API breakage in freeradius-client 1.1.8
FreeRADIUS client 1.1.8 introduced this backwards-incompatible API change:
https://github.com/FreeRADIUS/freeradius-client/commit/50d78bb53f4f341aa708e196b8955cacbae59669

Signed-off-by: Dimitri Papadopoulos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>
2025-05-23 11:29:14 +02:00
Dimitri Papadopoulos f007cce818 Modify the header file for C99 compatibility
Signed-off-by: Dimitri Papadopoulos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>
2025-04-02 09:07:32 +02:00
Dimitri Papadopoulos 8fab36aa12 Update to the last version in the Gnulib repository
git://git.sv.gnu.org/gnulib.git

Latest changes are from 2025-01-01.

Signed-off-by: Dimitri Papadopoulos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>
2025-04-02 09:07:02 +02:00
Dimitri Papadopoulos e21f08fb97 Do not apply clang-format to vendored files
Signed-off-by: Dimitri Papadopoulos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>
2025-04-02 09:05:42 +02:00
Dimitri Papadopoulos e8139682fb Move cloexec.* files out of common
These files are only used by the main program.

Signed-off-by: Dimitri Papadopoulos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>
2025-04-02 09:05:42 +02:00
Dimitri Papadopoulos Orfanos 43bd5d48c9 Merge branch 'master' into 'master'
Make path to ocserv-fw script conform to config prefix

See merge request openconnect/ocserv!448
2025-03-25 22:18:56 +01:00
Dimitri Papadopoulos 4eac8d29f4 occtl requires readline, it's not optional
Signed-off-by: Dimitri Papadopoulos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>
2025-03-12 22:09:43 +01:00
Dimitri Papadopoulos Orfanos 30de6d0b44 Merge branch 'tmp-listen-host' into 'master'
Option `listen-host` expects a single IP address

Closes #635

See merge request openconnect/ocserv!447
2025-03-02 18:32:12 +00:00
Dimitri Papadopoulos 78658605c9 updated to protobuf 1.5.1
Signed-off-by: Dimitri Papadopoulos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>
2025-03-02 19:30:44 +01:00
Dimitri Papadopoulos 4a4c341b45 Option listen-host expects a single IP address
Signed-off-by: Dimitri Papadopoulos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>
2025-03-02 19:07:22 +01:00
Dimitri Papadopoulos 63093e7392 Fix new typos detected by codespell
These are debatable, but so be it.

Signed-off-by: Dimitri Papadopoulos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>
2025-02-20 18:55:32 +01:00
Dimitri Papadopoulos bab0561111 silence coverity
CID 530817:  Resource leaks  (RESOURCE_LEAK)
Variable "ss" going out of scope leaks the storage "ss.ss_sp" points to.

Signed-off-by: Dimitri Papadopoulos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>
2025-01-14 15:30:51 +01:00
Dimitri Papadopoulos 3d0c95580a Modernize printf() format
Use macro constants from <inttypes.h> to print width-based integral
types from <stdint.h>.

Signed-off-by: Dimitri Papadopoulos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>
2024-12-06 17:26:49 +01:00
Dimitri Papadopoulos 5d1eeee8ca Main() signature compliant with C standard
Signed-off-by: Dimitri Papadopoulos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>
2024-12-06 12:08:52 +01:00
Dimitri Papadopoulos caeb4fa103 Follow-up to cf56c975: remove http-parser
Delete last occurrence of http-parser.

Signed-off-by: Dimitri Papadopoulos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>
2024-09-09 21:34:29 +02:00
Dimitri PapadopoulosandDimitri Papadopoulos d72fd7ee58 Use apt-get instead of yum on Debian/Ubuntu
Thank you @sergius_fidelis for reporting it.

Signed-off-by: Dimitri Papadopoulos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>
2024-08-22 12:04:04 +03:00
Dimitri PapadopoulosandDimitri Papadopoulos aca9b34285 Update build dependencies
Signed-off-by: Dimitri Papadopoulos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>
2024-08-22 12:03:50 +03:00
Dimitri Papadopoulos Orfanos d0e8ff2f96 Merge branch 'tmp-remove' into 'master'
Check return value of remove()

See merge request openconnect/ocserv!427
2024-07-03 20:48:20 +00:00
Dimitri Papadopoulos Orfanos 18099f98a5 Merge branch 'strdup' into 'master'
src/ocpasswd/ocpasswd.c: handle strdup errors

See merge request openconnect/ocserv!428
2024-07-03 20:25:16 +00:00
Dimitri Papadopoulos 6746d1d6f4 Check return value of remove()
Signed-off-by: Dimitri Papadopoulos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>
2024-06-25 22:13:21 +02:00
Dimitri Papadopoulos Orfanos 8cd5e12e81 Merge branch 'MAX_GROUPS' into 'master'
Bump MAX_GROUPS to allow for more groups

See merge request openconnect/ocserv!415
2024-03-26 20:16:21 +00:00
Dimitri Papadopoulos Orfanos 6728eb2436 Merge branch 'malloc.h' into 'master'
Do not include <malloc.h> but for malloc_trim()

See merge request openconnect/ocserv!418
2024-03-26 14:25:41 +00:00
Dimitri Papadopoulos 20ed2bfc7a Do not include <malloc.h> but for malloc_trim()
Signed-off-by: Dimitri Papadopoulos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>
2024-03-22 13:56:38 +01:00
Dimitri Papadopoulos c734a9c929 Bump MAX_GROUPS to allow for more groups
Especially Radius accounts might belong to a large number of groups.

Signed-off-by: Dimitri Papadopoulos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>
2024-03-19 07:53:15 +01:00
Dimitri PapadopoulosandNikos Mavrogiannopoulos ab58d9e9d7 Retrieve connection speed from RADIUS
Hijack Roaring Penguin's RADIUS attributes for that purpose:
* RP-Upstream-Speed-Limit → rx_per_sec
* RP-Downstream-Speed-Limit → tx_per_sec

While the ocserv configuration options use b/s, ocserv uses kb/s
internally. The radius attributes are already expressed in kb/s,
so we don't need to convert them.

Signed-off-by: Dimitri Papadopoulos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>
2024-01-20 20:12:34 +01:00