Commit Graph

3372 Commits

Author SHA1 Message Date
Alan Jowett
c106bb86fc Merge branch 'issue363' into 'master'
Latency stats should be at LOG_DEBUG not LOG_INFO level

Closes #363

See merge request openconnect/ocserv!225
2020-10-07 19:52:35 +00:00
Alan Jowett
f0f90ef4d7 Merge branch 'issue362' into 'master'
TCP health probes shouldn't be logged at INFO level

Closes #362

See merge request openconnect/ocserv!224
2020-10-07 19:39:40 +00:00
Alan Jowett
cd0f382628 Latency stats should be at LOG_DEBUG not LOG_INFO level
Resolves: #363

Signed-off-by: Alan Jowett alan.jowett@microsoft.com
2020-10-07 13:09:05 -06:00
Alan Jowett
7ffb4d1ca2 TCP health probes shouldn't be logged at INFO level
Resolves: #362

Signed-off-by: Alan Jowett alan.jowett@microsoft.com
2020-10-07 12:56:24 -06:00
Nikos Mavrogiannopoulos
f8ff70a098 NEWS: updated
Signed-off-by: Nikos Mavrogiannopoulos <n.mavrogiannopoulos@gmail.com>
2020-10-02 21:56:48 +02:00
Alan Jowett
f94b54341e Merge branch 'issue360' into 'master'
Don't apply BanIP checks to clients on the same subnet.

Closes #360

See merge request openconnect/ocserv!222
2020-10-01 21:22:45 +00:00
Alan Jowett
5b402014fd Don't apply BanIP checks to clients on the same subnet.
Resolves #360

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
2020-10-01 11:59:41 -06:00
Alan Jowett
8cc7fed172 Merge branch 'issue357-part1' into 'master'
Don't attempt TLS if the client closes the connection with zero data sent.

Closes #357

See merge request openconnect/ocserv!221
2020-09-30 22:46:37 +00:00
Alan Jowett
7a924b6d9c Don't attempt TLS if the client closes the connection with zero data sent.
Resolves #357

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
2020-09-30 16:03:38 -06:00
Nikos Mavrogiannopoulos
7c0c6ec1ad Merge branch 'tmp-remove-todo' into 'master'
Removed TODO file; it is out-of-date

See merge request openconnect/ocserv!220
2020-09-30 19:06:06 +00:00
Nikos Mavrogiannopoulos
333bbd536c Removed TODO file; it is out-of-date
Signed-off-by: Nikos Mavrogiannopoulos <n.mavrogiannopoulos@gmail.com>
2020-09-30 20:00:26 +02:00
Nikos Mavrogiannopoulos
71e36ccae4 README.md: corrected links
Signed-off-by: Nikos Mavrogiannopoulos <n.mavrogiannopoulos@gmail.com>
2020-09-29 23:43:07 +02:00
Nikos Mavrogiannopoulos
2a1e91795b Merge branch 'tmp-drain-ms-repro' into 'master'
Stop listening on ocserv-sm socket on error to prevent looping.

Closes #356

See merge request openconnect/ocserv!219
2020-09-29 21:39:09 +00:00
Alan Jowett
12c3d62276 Stop listening on ocserv-sm socket on error to prevent looping.
Resolves #356

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
2020-09-29 22:51:52 +02:00
Nikos Mavrogiannopoulos
53c8c0f139 tests: added reproducer for drain-server-ms failure
Signed-off-by: Nikos Mavrogiannopoulos <n.mavrogiannopoulos@gmail.com>
2020-09-29 22:51:47 +02:00
Nikos Mavrogiannopoulos
58c08279bd sample.config: moved server-drain-ms to a more suitable section of the file
Signed-off-by: Nikos Mavrogiannopoulos <n.mavrogiannopoulos@gmail.com>
2020-09-29 21:37:26 +02:00
Nikos Mavrogiannopoulos
067c96cb06 tests: renamed test-drain-server to drain-server
Signed-off-by: Nikos Mavrogiannopoulos <n.mavrogiannopoulos@gmail.com>
2020-09-29 21:07:47 +02:00
Nikos Mavrogiannopoulos
5879a6b6dd .mailmap: added aliases of Mike
Signed-off-by: Nikos Mavrogiannopoulos <n.mavrogiannopoulos@gmail.com>
2020-09-22 21:59:02 +02:00
Nikos Mavrogiannopoulos
21c6b981be .mailmap: added aliases of Alan
Signed-off-by: Nikos Mavrogiannopoulos <n.mavrogiannopoulos@gmail.com>
2020-09-22 21:57:33 +02:00
Nikos Mavrogiannopoulos
b9f8ea6b6c bumped version for 1.1.1 release
Signed-off-by: Nikos Mavrogiannopoulos <n.mavrogiannopoulos@gmail.com>
1.1.1
2020-09-21 12:21:21 +02:00
Nikos Mavrogiannopoulos
3426b8f6c9 ocpasswd.8: document the current behavior of ignoring groups
Resolves: #353

Signed-off-by: Nikos Mavrogiannopoulos <n.mavrogiannopoulos@gmail.com>
2020-09-21 12:16:51 +02:00
Nikos Mavrogiannopoulos
61c2b5c155 Merge branch 'tmp-nanosleep' into 'master'
disable_system_calls: added clock_nanosleep

See merge request openconnect/ocserv!216
2020-09-21 07:24:23 +00:00
Nikos Mavrogiannopoulos
8208f74138 disable_system_calls: added clock_nanosleep
It seems that new fedora versions depend on it for nanosleep().

Signed-off-by: Nikos Mavrogiannopoulos <n.mavrogiannopoulos@gmail.com>
2020-09-21 08:41:32 +02:00
William Dauchy
3ba9ebdab0 tests, radius-group: fix unstable tests
- print outfile instead of new command; this will help debug when an
  issue occurs, to know what was the original output
- also add some time between tests to avoid race; this was failing on
  "could not find group information"

  Established DTLS connection (using GnuTLS). Ciphersuite (DTLS1.2)-(PSK)-(AES-256-GCM).
      inet 192.168.93.190/32 scope global tun0
  PING 192.168.93.1 (192.168.93.1) 56(84) bytes of data.
  64 bytes from 192.168.93.1: icmp_seq=1 ttl=64 time=0.217 ms
  64 bytes from 192.168.93.1: icmp_seq=2 ttl=64 time=0.246 ms
  64 bytes from 192.168.93.1: icmp_seq=3 ttl=64 time=0.235 ms

  --- 192.168.93.1 ping statistics ---
  3 packets transmitted, 3 received, 0% packet loss, time 2052ms
  rtt min/avg/max/mdev = 0.217/0.232/0.246/0.011 ms

  could not find group information

Signed-off-by: William Dauchy <w.dauchy@criteo.com>
2020-09-20 22:11:25 +02:00
William Dauchy
80babceacf listen-netns: fix worker case for DTLS
while using udp, we later open a file descriptor for the worker. With a
listen netns config, I overlooked this case which oblige me to move the
struct containing the file descriptor in the main one. Then I can access
them from each worker to make it possible to open the socket in the
correct netns. I also need to keep the netns fd open during the whole
life of the process.

the issue was not visible on a tcp-only case, but while using udp you
can see logs such as:

main[user]: x.x.x.x:54024 bind UDP to 0.0.0.0:443: Cannot assign requested address
worker[user]: x.x.x.x setting up DTLS-PSK connection
main[user]: x.x.x.x:54024 bind UDP to 0.0.0.0:443: Cannot assign requested address

update tests to reflects that:
- instead of creating our own netns, use the one created in common.sh
- we start server in ns1, but listen in ns2, and test client from ns3
  (we don't want to listen in ns1 to test listen-ns)

Signed-off-by: William Dauchy <w.dauchy@criteo.com>
2020-09-20 21:49:08 +02:00
Nikos Mavrogiannopoulos
8f6ff20f66 Merge branch 'minor' into 'master'
cosmetic fixes for rx/tx per sec limit

See merge request openconnect/ocserv!214
2020-09-16 12:17:06 +00:00
Yousong Zhou
c47911a7d0 Fix typo in comment of sample config
Signed-off-by: Yousong Zhou <yszhou4tech@gmail.com>
2020-09-15 19:14:50 +08:00
Yousong Zhou
5cb41a570b Fix display of rx/tx per sec limit
Signed-off-by: Yousong Zhou <yszhou4tech@gmail.com>
2020-09-15 19:14:37 +08:00
Nikos Mavrogiannopoulos
f1c093f8a8 Merge branch 'tmp-ocserv-group' into 'master'
radius: ignore redundant group class

Closes #332

See merge request openconnect/ocserv!213
2020-09-07 18:05:06 +00:00
Nikos Mavrogiannopoulos
6be284dd63 radius: ignore redundant group class
This ignores any items following the first group class attribute.

Resolves: #332

Signed-off-by: Nikos Mavrogiannopoulos <n.mavrogiannopoulos@gmail.com>
2020-09-03 14:35:31 +02:00
Nikos Mavrogiannopoulos
dbbf7fe3e0 ns.sh: conditionally call IP with NSNAME3 route
This fixes operation in Fedora 32.

Signed-off-by: Nikos Mavrogiannopoulos <n.mavrogiannopoulos@gmail.com>
2020-09-03 14:34:03 +02:00
Alan Jowett
5b3b8e8d33 Merge branch 'issue345' into 'master'
Stop accepting new TCP connections when the server is at maximum active connection capacity & add support for gracefully stopping the server.

Closes #345

See merge request openconnect/ocserv!212
2020-09-02 14:51:05 +00:00
Alan Jowett
77dfa36c71 Stop accepting new TCP connections when the server is at maximum active connection capacity.
Add support for gracefully stopping the server.
Add primer on using ocserv with L3 load balancer.

Resolves: #345

Signed-off-by: Alan Jowett <alanjo@microsoft.com>
2020-08-28 16:01:35 -06:00
Alan Jowett
e5191bf4f3 Merge branch 'issue341' into 'master'
Modify ocserv-sm to permit it to scale up to the number of CPUs. This permits...

Closes #341

See merge request openconnect/ocserv!210
2020-08-26 16:44:43 +00:00
Alan Jowett
945699097d Modify ocserv-sm to permit it to scale up to the number of CPUs. This permits a higher rate of client connections and prevents TLS signing from becoming a bottleneck for clients connecting.
Resolves: #341

Signed-off-by: Alan Jowett <alanjo@microsoft.com>
2020-08-26 09:46:04 -06:00
Nikos Mavrogiannopoulos
44a1357083 Merge branch 'tmp-domain-suffix' into 'master'
sample.config: documented how to specify multiple default domains

Closes #328

See merge request openconnect/ocserv!206
2020-08-10 18:44:07 +00:00
Nikos Mavrogiannopoulos
e5fced512f Merge branch 'tmp-test-updates2' into 'master'
tests: eliminate legacy docker tests

See merge request openconnect/ocserv!209
2020-08-09 20:13:31 +00:00
Nikos Mavrogiannopoulos
d0a509c6c3 tests: introduced new proxy protocol tests
This replaces the old no longer used "docker-tests".

Signed-off-by: Nikos Mavrogiannopoulos <n.mavrogiannopoulos@gmail.com>
2020-08-09 21:32:27 +02:00
Nikos Mavrogiannopoulos
5021c994db tests: always use @ISOLATE_WORKERS@
Now all tests configs are being auto-generated, so this variable
will be replaced.

Signed-off-by: Nikos Mavrogiannopoulos <n.mavrogiannopoulos@gmail.com>
2020-08-09 19:56:37 +02:00
Nikos Mavrogiannopoulos
8f3dd01483 sample.config: disable all legacy TLS versions by default
Signed-off-by: Nikos Mavrogiannopoulos <n.mavrogiannopoulos@gmail.com>
2020-08-09 18:41:24 +02:00
Nikos Mavrogiannopoulos
c914b8d398 Merge branch 'tmp-test-updates' into 'master'
test updates

Closes #340

See merge request openconnect/ocserv!207
2020-08-09 16:39:57 +00:00
Nikos Mavrogiannopoulos
d84272ffed tests: added test for ping-leases
Resolves: #340

Signed-off-by: Nikos Mavrogiannopoulos <n.mavrogiannopoulos@gmail.com>
2020-08-09 17:59:04 +02:00
Nikos Mavrogiannopoulos
b2c0c6c1cf tests: replaced explicit ports with random assignment
Signed-off-by: Nikos Mavrogiannopoulos <n.mavrogiannopoulos@gmail.com>
2020-08-09 13:14:22 +02:00
Nikos Mavrogiannopoulos
f814cf851b tests: added session resumption test
Signed-off-by: Nikos Mavrogiannopoulos <n.mavrogiannopoulos@gmail.com>
2020-08-09 11:54:04 +02:00
Nikos Mavrogiannopoulos
edbb1e7111 sample.config: documented how to specify multiple default domains
It is possible to specify multiple domains in X-CSTP-Default-Domain for
openconnect clients; make sure that this is documented.

Resolves: #328

Signed-off-by: Nikos Mavrogiannopoulos <n.mavrogiannopoulos@gmail.com>
2020-08-06 20:57:22 +02:00
Nikos Mavrogiannopoulos
ae9f299b0f Merge branch 'tmp-warn-in-password-auth' into 'master'
config: error when multiple password authentication methods are present

See merge request openconnect/ocserv!205
2020-08-06 11:10:53 +00:00
Nikos Mavrogiannopoulos
c3e62fe7a3 Merge branch 'tmp-enable-asan' into 'master'
.gitlab-ci.yml: reenable address sanitizer

See merge request openconnect/ocserv!202
2020-08-06 11:10:13 +00:00
Nikos Mavrogiannopoulos
0ecef93423 .gitlab-ci.yml: reenable address sanitizer
This disables all the tests that use LD_PRELOAD, and thus limits
the test suite on the tests that are run as root.

Signed-off-by: Nikos Mavrogiannopoulos <n.mavrogiannopoulos@gmail.com>
2020-08-05 23:08:43 +02:00
Nikos Mavrogiannopoulos
7a7d432d0f use REMOTE_HOSTNAME to pass the user's advertised hostname
The previously used HOSTNAME variable is being overriden by bash and
thus was not a reliable one. We switch to setting REMOTE_HOSTNAME,
but keep the HOSTNAME for compatibility.

This also changes 'test-pass-script' to check for the new variable.

Signed-off-by: Nikos Mavrogiannopoulos <n.mavrogiannopoulos@gmail.com>
2020-08-05 23:05:24 +02:00
Nikos Mavrogiannopoulos
08c0eecc85 config: error when multiple password authentication methods are present
This prevents starting a server with an invalid configuration.

Signed-off-by: Nikos Mavrogiannopoulos <n.mavrogiannopoulos@gmail.com>
2020-08-05 22:46:24 +02:00